Model Conversion

CanJS

thecounto..

in CanJS • 1 year ago

In JMVC I used to do this:

can.Model("Thing", {
findAll : function(params, success, error) {
return can.ajax({
url: '/things',
type: 'get',
dataType: 'json thing.models',
data: params,
success: success,
error: error
});
}
}, {});

Is this still necessary in CanJS?

It seems to be giving me errors.

Uncaught fixtures.js Error parsererror Error: No conversion from json to thing.models

This is with fixtures turned on.

With fixtures turned off I get the following error:

Uncaught TypeError: Function.prototype.apply: Arguments list has wrong type

If I removed the converter line in bold above (thing.models), it seems to work fine. Trying to remember why I have it there.

Thanks,

Mike

Replies(14)

Curtis Cu..

Re: Model Conversion

1 year ago

JMVC used ajax converters to convert a JSON response into a list of model instances so 'json thing.models' was required.

In CanJS, this conversion is done for you automatically so you just need a dataType of json.

thecounto..

Re: Model Conversion

1 year ago

Got it. Makes things easier.

Another slightly related question.

How do I access attributes like shortName and fullName on one of my models. I am getting undefined unless I get at it like:

var fullName = myModel.__proto__.constructor.fullName;

But that doesn't seem right.

Curtis Cu..

Re: Model Conversion

1 year ago

myModel.fullName and myModel._shortName

This only works if you pass a name to can.Model as the first parameter. If you don't you will get null for the fullName and 'model' for the shortName.

thecounto..

Re: Model Conversion

1 year ago

I have passed a named to can.Model, but those are returning "undefined"...

myModel.constructor.fullName works fine though

Curtis Cu..

Re: Model Conversion

1 year ago

Here's a fiddle showing this working in CanJS: http://jsfiddle.net/donejs/DjYcY/1/

thecounto..

Re: Model Conversion

1 year ago

Curtis,

I am talking about accessing those attributes on an instance of a model.

I've updated the fiddle:

http://jsfiddle.net/thecountofzero/DjYcY/3/

Curtis Cu..

Re: Model Conversion

1 year ago

In that case, just use m.constructor.fullName or m.constructor._shortName.

Updated the fiddle

thecounto..

Re: Model Conversion

1 year ago

Could you possibly explain why you need to type .constructor?

How come just doing .fullName doesn't find it up to prototype chain?

Justin Me..

Re: Model Conversion

1 year ago

because it's not on the proto chain. It's added to the static properties of the Constructor function.

mr.pohoda

Re: Model Conversion

1 year ago

I use findOne in model like this (using canJS), which works great and it returns json.

findOne: 'GET http://dev.snowhit.com/skicentres/lines/detail-line/id/{id}'

Now I need to change one attribute in the returned json before it's passed to can.Control.

findOne : function(params){
var data;
$.ajax({
url: 'http://dev.snowhit.com/skicentres/lines/detail-line/id/' + params.id,
type: 'get',
dataType: 'json'
}).done(function(data){
data['line'] = 123;
return data;
})
}

I've tried this but it does not work. It does not wait for ajax to complete. Attribute change to 123 is just an example, I need to call different web service instead.

Thank you for any help, I couldn't find any explanation here http://donejs.com/docs.html#!can.Model.static.findOne

thecounto..

Re: Model Conversion

1 year ago

Put a return statement before $.ajax

mr.pohoda

Re: Model Conversion

1 year ago

Thank you, this works perfectly. Everyday I learn something new :-)

Justin Me..

Adding the return statement works, but works in a "tricky" way. Essentially, you are mutating what the deferred will resolve. I'm not sure this is the intended philosophy of deferreds. If some other code did this, you'd be rather annoyed. However, this is fast.

For a slower, but more robust solution, you could use pipe, copy the data, change the property, and return it.

I'm not saying you should use pipe, more you should know it exists for these types of things.

thecounto..

Re: Model Conversion

1 year ago

Or something like this:

myFilter = function(instances) {

// Update whatever you want
return instances;
},

findOne: function(params, success, error) {
var self = this;
return $.ajax({
url: URL,
type: 'get',
dataType: 'json',
data: params,
success: this.callback(['myFilter', success]),
error: error
});
},

I think something like this should work.

Top Reply

Response title

Attachments

New to this Portal?